[darwin] Upstream __isPlatformOrVariantPlatformVersionAtLeast() #9007
Conversation
egorzhdan
left a comment
egorzhdan
left a comment
There was a problem hiding this comment.
I think this patch could be submitted to the upstream LLVM repo, since it isn't very specific to Swift. That would help us avoid auto-merger conflicts in the future.
|
Indeed, please upstream this to compiler-rt directly. Not having this in upstream LLVM will cause problems if we ever want to make sure of this functionality in other components. |
|
I will upstream this to upstream LLVM. However, this PR is still needed to make the change available to Swift's |
|
Created the upstream PR here: llvm#100605 |
|
This assumes that upstream will take the PR exactly as-is. If changes are needed to this function to make it acceptable upstream, we will end up not only with a merge conflict but potentially with internal stuff that relies on one definition, when upstream has a slightly different definition. This happened for e.g. IMO the fastest way to proceed is to not rush, and to land this upstream first. |
|
@ldionne I am waiting for llvm#100605 to land first but I wanted to get CI feedback for the change here. |
Add `__isPlatformOrVariantPlatformVersionAtLeast()` which is used to check OS version availability from zippered libraries on macOS. This routine is needed for complete macCatalyst support in the Swift compiler.
tshortli
force-pushed
the
upstream-is-platform-or-variant-platform-version-at-least-20230725
branch
from
5014f4d to
f37c638
Compare
|
@swift-ci test llvm |
|
@swift-ci test |
|
@swift-ci test Linux |
tshortli
deleted the
upstream-is-platform-or-variant-platform-version-at-least-20230725
branch
3 participants
Add
__isPlatformOrVariantPlatformVersionAtLeast()which is used to check OS version availability from zippered libraries on macOS. This routine is needed for complete macCatalyst support in the Swift compiler.