[APINotes] Support SwiftImportAs for C++ structs
#7386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I will also submit a part of this patch for review upstream once it is approved. |
compnerd
approved these changes
Sep 4, 2023
Member
compnerd
left a comment
compnerd
left a comment
There was a problem hiding this comment.
Would be good to start flowing this upstream.
Comment on lines
541
to
545
Member
There was a problem hiding this comment.
What do you think of this pattern?
Suggested change
| if (ImportAsLength > 0) { | |
| info.SwiftImportAs = (std::string(reinterpret_cast<const char *>(data), | |
| ImportAsLength - 1)); | |
| data += ImportAsLength - 1; | |
| } | |
| if (auto BiasedLength = ImportAsLength - 1) { | |
| info.SwiftImportAs = (std::string(reinterpret_cast<const char *>(data), | |
| BiasedLength)); | |
| data += BiasedLength; | |
| } |
Author
There was a problem hiding this comment.
This underflows unsigned if ImportAsLength == 0, we could cast it to signed but I think that would slightly hurt readability.
This allows annotating C++ types as e.g. immortal references using API Notes. This is based on the original patch by Zoe (411d3ab). rdar://114933812
egorzhdan
force-pushed
the
egorzhdan/apinotes-importas
branch
from
09b5066 to
e751b39
Compare
zoecarver
approved these changes
Sep 4, 2023
zoecarver
left a comment
zoecarver
left a comment
There was a problem hiding this comment.
This is super awesome! Thank you Egor! This will make a lot of people very happy :)
egorzhdan
added a commit
to egorzhdan/llvm-project
that referenced
this pull request
Sep 5, 2023
This upstreams a few Clang API Notes attributes that were recently added downstream in the Apple fork (swiftlang#7386).
egorzhdan
added a commit
to llvm/llvm-project
that referenced
this pull request
Sep 7, 2023
This upstreams a few Clang API Notes attributes that were recently added downstream in the Apple fork (swiftlang#7386).
avillega
pushed a commit
to avillega/llvm-project
that referenced
this pull request
Sep 11, 2023
This upstreams a few Clang API Notes attributes that were recently added downstream in the Apple fork (swiftlang#7386).
qihangkong
pushed a commit
to rvgpu/llvm
that referenced
this pull request
Apr 18, 2024
This upstreams a few Clang API Notes attributes that were recently added downstream in the Apple fork (swiftlang/llvm-project#7386).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows annotating C++ types as e.g. immortal references using API Notes.
This is based on the original patch by Zoe (411d3ab).
rdar://114933812