Added -fcas-emit-casid-file to emit a .casid file #7305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rastogishubham
requested review from
adrian-prantl,
cachemeifyoucan and
felipepiovezan
Author
|
@swift-ci please test llvm |
|
Nice! It might make future cherry-picking easier if we separate the clang and llvm changes into separate commits. |
cachemeifyoucan
left a comment
cachemeifyoucan
left a comment
There was a problem hiding this comment.
LGTM in general.
Other suggestion I will make is to make all the CASIDOS to be the last parameter with a default value (nullptr) when possible. That will keep the diff a lot smaller downstream. It can be re-ordered when upstreaming.
Also since this is a LLVM CodeGen option, I prefer the bulk of the testing should be done in llvm test. That is using llvm-mc or llc to test CASID file output. Instead of using clang to do all the testing.
With -fcas-emit-casid-file, a .casid file will be emitted next to the object file only when -fcas-backend-mode=native, or -fcas-backend-mode=verify is used and the output is directed to a file, rather than stdout.
This change enables -fcas-emit-casid-file to the llvm backend and allows emission of a .casid file when -fcas-backend and -fcas-backend-mode=native or -fcas-backend-mode=verify is used
rastogishubham
force-pushed
the
EmitCASID
branch
from
cf715a3 to
bd5fc55
Compare
Author
|
@swift-ci please test |
Author
|
@swift-ci please test llvm |
1 similar comment
Author
|
@swift-ci please test llvm |
This was referenced Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With -fcas-emit-casid-file, a .casid file will be emitted next to the object file only when -fcas-backend-mode=native, or -fcas-backend-mode=verify is used and the output is directed to a file, rather than stdout.