Avoid instantiating SwiftASTContextForModule in get_executable_triple… #7265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@swift-ci test |
kastiglione
approved these changes
Aug 17, 2023
…() (NFC) Instead we can directly query the triple of the module. rdar://113997661
This fixes an oversight that was uncovered by making it less likely to instantiate a per-module SwiftASTContext.
adrian-prantl
force-pushed
the
113997661-exe-triple-5.9
branch
from
77499cd to
ca58189
Compare
Author
|
Added a bugfix for path remapping that was uncovered by this change! |
Author
|
@swift-ci test |
Author
|
@swift-ci test windows |
1 similar comment
Author
|
@swift-ci test windows |
kastiglione
reviewed
Aug 18, 2023
| # Turn on logging. | ||
| log = self.getBuildArtifact("types.log") | ||
| self.expect("log enable lldb types -f " + log) | ||
| self.expect('log enable lldb types -f "%s"' % log) |
There was a problem hiding this comment.
we can use python f-strings now:
Suggested change
| self.expect('log enable lldb types -f "%s"' % log) | |
| self.expect(f'log enable lldb types -f "{log}"') |
Author
There was a problem hiding this comment.
Nice, I did not know about this feature!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…() (NFC)
Instead we can directly query the triple of the module.
rdar://113997661