Skip to content

Move some breakpoints onto prints to prevent improved codegen from breaking tests. #6888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2023
Merged

Move some breakpoints onto prints to prevent improved codegen from breaking tests. #6888

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions lldb/test/API/lang/swift/variables/consume_operator/main.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@ public func copyableVarTest() {
print("stop here") // Set breakpoint
var k = Klass()
k.doSomething()
let m = consume k // Set breakpoint
print("stop here") // Set breakpoint
let m = consume k
m.doSomething()
k = Klass() // Set breakpoint
k.doSomething() // Set breakpoint
Expand All @@ -61,7 +62,8 @@ public func addressOnlyVarTest<T : P>(_ x: T) {
print("stop here") // Set breakpoint
var k = x
k.doSomething()
let m = consume k // Set breakpoint
print("stop here") // Set breakpoint
let m = consume k
m.doSomething()
k = x // Set breakpoint
k.doSomething() // Set breakpoint
Expand All @@ -81,7 +83,8 @@ public func copyableValueArgTest(_ k: __owned Klass) {
public func copyableVarArgTest(_ k: inout Klass) {
print("stop here") // Set breakpoint
k.doSomething()
let m = consume k // Set breakpoint
print("stop here") // Set breakpoint
let m = consume k
m.doSomething()
k = Klass() // Set breakpoint
k.doSomething() // Set breakpoint
Expand All @@ -98,7 +101,8 @@ public func addressOnlyValueArgTest<T : P>(_ k: __owned T) {
public func addressOnlyVarArgTest<T : P>(_ k: inout T, _ x: T) {
print("stop here") // Set breakpoint
k.doSomething()
let m = consume k // Set breakpoint
print("stop here") // Set breakpoint
let m = consume k
m.doSomething()
k = x // Set breakpoint
k.doSomething() // Set breakpoint
Expand Down Expand Up @@ -132,7 +136,8 @@ public func copyableVarTestCCFlowTrueReinitOutOfBlockTest() {
var k = Klass() // Set breakpoint
k.doSomething()
if trueBoolValue {
let m = consume k // Set breakpoint
print("stop here") // Set breakpoint
let m = consume k
m.doSomething() // Set breakpoint
}
k = Klass() // Set breakpoint
Expand All @@ -143,7 +148,8 @@ public func copyableVarTestCCFlowTrueReinitInBlockTest() {
var k = Klass() // Set breakpoint
k.doSomething()
if trueBoolValue {
let m = consume k // Set breakpoint
print("stop here") // Set breakpoint
let m = consume k
m.doSomething()
k = Klass() // Set breakpoint
k.doSomething() // Set breakpoint
Expand Down
3 changes: 2 additions & 1 deletion lldb/test/API/lang/swift/variables/consume_operator_async/main.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@ public func copyableVarTest() async {
var k = Klass() // Set breakpoint 05
k.doSomething()
await forceSplit() // Set breakpoint 06
let m = consume k // Set breakpoint 07
print("stop here") // Set breakpoint 07
let m = consume k
m.doSomething() // Set breakpoint 08
await forceSplit()
k = Klass() // Set breakpoint 09
Expand Down