[lldb] Fix Language Plugin decl printing (#6795) #6819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`SwiftLanguage::GetDeclPrintingHelper` is a helper function used for Swift types. This
code contains some very similar logic to the default logic in `ValueObjectPrinter`.
Specifically:
`SwiftLanguage`:
```c++
else if (!options.m_hide_name)
stream.Printf(" =");
```
`ValueObjectPrinter`:
```c++
else if (ShouldShowName())
m_stream->Printf(" =");
```
The function `ValueObjectPrinter::ShouldShowName` is not accessible by `SwiftLanguage`.
To allow `SwiftLanguage` to make the right decision, and fit within the existing API
boundary, this change uses a custom print options, which sets calls `SetHideName`
according to the value of `ShouldShowName()`. This allows the Swift language decl
printing helper to correctly know whether to print the name, or not.
(cherry-picked from commit e6d9bd6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SwiftLanguage::GetDeclPrintingHelperis a helper function used for Swift types. Thiscode contains some very similar logic to the default logic in
ValueObjectPrinter.Specifically:
SwiftLanguage:ValueObjectPrinter:The function
ValueObjectPrinter::ShouldShowNameis not accessible bySwiftLanguage.To allow
SwiftLanguageto make the right decision, and fit within the existing APIboundary, this change uses a custom print options, which sets calls
SetHideNameaccording to the value of
ShouldShowName(). This allows the Swift language declprinting helper to correctly know whether to print the name, or not.
(cherry-picked from commit e6d9bd6)