Fix the check in StopInfoBreakpoint for "are we currently running an … #6625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…expression" We were checking "WasTheLastResumeForUserExpression" but that returns true even if that expression was completed, provided we haven't run again. This uses a better check. This is actually fairly hard to trigger. It happens the first time you hit an objc_exception_throw breakpoint and invoke that frame recognizer for that. But I couldn't trigger it using a Python based frame recognizer. So I wrote a test for the objc_exception_throw_breakpoint recognizer which should have been there anyway... It fails (the target auto-continues) w/o this patch and succeeds with it. Differential Revision: https://reviews.llvm.org/D147587 (cherry picked from commit f79c037)
Author
|
@swift-ci please test |
…=...) It doesn't exist on this branch.
Author
|
The test was failing because it relies on a lldbtest feature that isn't on the branch. I disabled that portion of the test. |
Author
|
@swift-ci please test |
Member
|
@swift-ci please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…expression"
We were checking "WasTheLastResumeForUserExpression" but that returns true even if that expression was completed, provided we haven't run again. This uses a better check.
This is actually fairly hard to trigger. It happens the first time you hit an objc_exception_throw breakpoint and invoke that frame recognizer for that. But I couldn't trigger it using a Python based frame recognizer. So I wrote a test for the objc_exception_throw_breakpoint recognizer which should have been there anyway... It fails (the target auto-continues) w/o this patch and succeeds with it.
Differential Revision: https://reviews.llvm.org/D147587
(cherry picked from commit f79c037)