Cherry pick trampoline support #6565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@swift-ci test |
The `transparent_stepping` attribute is intended as a hint for debuggers that this function itself is not interesting, but it calls a function that might be. So, when stepping in arrives at a function with this attribute, debuggers should transparently step-in through it into the functions called by the annotated function (but not by subsequent calls made by those functions), stopping at the first one its normal rules for whether to stop says to stop at - or stepping out again if none qualify. Also, when stepping out arrives at a function with this attribute, the debugger should continue stepping out to its caller. Differential Revision: https://reviews.llvm.org/D146595 (cherry picked from commit 115648d)
adrian-prantl
approved these changes
Mar 31, 2023
adrian-prantl
left a comment
adrian-prantl
left a comment
There was a problem hiding this comment.
We may rename the clang attribute later, but for now, this LGTM.
This patch adds support for the DW_AT_trampoline attribute whose value is a boolean. Which is a "generic trampoline". Stepping into a generic trampoline by default will step through the function, checking at every branch, until we stop in a function which makes sense to stop at (a function with debug info, which isn't a trampoline, for example). Differential Revision: https://reviews.llvm.org/D147292 (cherry picked from commit 4a8e545)
augusto2112
force-pushed
the
cherry-pick-trampoline-support
branch
from
8ce80f1 to
2af4818
Compare
Author
|
@swift-ci test |
Author
|
@swift-ci test macOS |
3 similar comments
Author
|
@swift-ci test macOS |
Author
|
@swift-ci test macOS |
Author
|
@swift-ci test macOS |
Author
|
Swift asan validation tests timed out: |
Author
|
@swift-ci test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.