Add support for generic expression evaluation in variadic generic con… #6505
Conversation
|
@swift-ci test |
| // pointers in the wrapper, so we can pass them as opaque pointers in the | ||
| // trampoline function later on. | ||
| if (m_bind_generic_types == lldb::eDontBind && variable.IsMetadataPointer()) | ||
| if (m_bind_generic_types == lldb::eDontBind && |
There was a problem hiding this comment.
Are we relying in the same --bind-generic-types mechanism to enable this behavior? It seems to me this would never work in the "bind" mode.
| return {}; | ||
| return swift::Type(it->second); | ||
| } | ||
| //swift_ast_ctx->GetBuiltinRawPointerType()); |
| // in that case. | ||
| const auto introducer = variable.IsSelf() ? swift::VarDecl::Introducer::Var | ||
| : variable.GetVarIntroducer(); | ||
| const auto introducer = (variable.IsSelf() || variable.IsUnboundPack()) |
There was a problem hiding this comment.
I'm curious, why does the unbound pack need to be mutated?
| subs) { | ||
| auto tss = type.GetTypeSystem().dyn_cast_or_null<TypeSystemSwift>(); | ||
| if (!tss) | ||
| return "<unexpected typesystem>"; |
There was a problem hiding this comment.
Maybe this function should return an llvm::Expected?
| /// lldb_sink($__lldb_arg, $__lldb_injected_self, $τ_0_0, $τ_0_1, ..., $τ_0_n) | ||
| static CallsAndArgs MakeGenericSignaturesAndCalls( | ||
| llvm::ArrayRef<SwiftASTManipulator::VariableInfo> local_variables) { | ||
| static llvm::Expected<CallsAndArgs> MakeGenericSignaturesAndCalls( |
There was a problem hiding this comment.
Update the doxygen comment explaining the new functionality and the new parameters?
| /// lldb_sink($__lldb_arg, $__lldb_injected_self, $τ_0_0, $τ_0_1, ..., $τ_0_n) | ||
| static CallsAndArgs MakeGenericSignaturesAndCalls( | ||
| llvm::ArrayRef<SwiftASTManipulator::VariableInfo> local_variables) { | ||
| static llvm::Expected<CallsAndArgs> MakeGenericSignaturesAndCalls( |
There was a problem hiding this comment.
This functions seems to be doing quite a lot now, and a lot of the new behavior depends on whether generic_sig exists and if needs_object_ptr is true/false, I wonder if it'd be possible to split it up in maybe 2,3 functions
2 participants
…texts.