[ASAN] Removed special case controlling allocator consts for __aarch64 #6294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch64__. This patch should land before D137136 to make sure that the leak sanitizer allocator works correctly. This patch is NFC without D137136. Reviewed By: vitalybuka Differential Revision: https://reviews.llvm.org/D137265 (cherry picked from commit a8604f2)
|
My understanding of the issue is: there was an open source change consisting of multiple commits. The Swift stable branch “branched off” in between: we have some but not all of these commits that should land “as a unit”. I would prefer to revert the other commits of this set of commits, instead of cherry-picking this one because of what you said:
|
Author
|
Decided to go with solution proposed by yln (reverting), therefore closing this without merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch should land before D137136 to make sure that the leak sanitizer allocator works correctly. This patch is NFC without D137136.
Reviewed By: vitalybuka
Differential Revision: https://reviews.llvm.org/D137265
(cherry picked from commit a8604f2)