Skip to content

VirtualOutputBackend Improvements for swift compiler #6112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 5, 2023
Merged

VirtualOutputBackend Improvements for swift compiler #6112

merged 3 commits into from
Apr 5, 2023

Conversation

@cachemeifyoucan
Copy link

@cachemeifyoucan cachemeifyoucan commented Jan 25, 2023

Some llvm level improvements for swift to virtualize output

@cachemeifyoucan cachemeifyoucan mentioned this pull request Jan 25, 2023
Merged
DougGregor
DougGregor previously approved these changes Jan 26, 2023
View reviewed changes
Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks reasonable to me, but I'll have a hard time commenting more without seeing the tie-in to a frontend.

@cachemeifyoucan
Copy link
Author

cachemeifyoucan commented Jan 26, 2023

This all looks reasonable to me, but I'll have a hard time commenting more without seeing the tie-in to a frontend.

Swift changes are here: swiftlang/swift#63206

benlangmuir
benlangmuir previously approved these changes Jan 26, 2023
View reviewed changes
Copy link

@benlangmuir benlangmuir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a few minor nits.

@cachemeifyoucan cachemeifyoucan force-pushed the eng/PR-VirtualOutputBackends-Improvements branch from 7189689 to 4b9f80b Compare January 26, 2023 22:35
@cachemeifyoucan
Copy link
Author

cachemeifyoucan commented Jan 27, 2023

Please test with following pull request:
swiftlang/swift#63206

@swift-ci please test

@cachemeifyoucan cachemeifyoucan force-pushed the eng/PR-VirtualOutputBackends-Improvements branch from 4b9f80b to 2655d80 Compare February 1, 2023 21:48
@cachemeifyoucan cachemeifyoucan changed the base branch from stable/20220421 to stable/20221013 February 1, 2023 21:48
@cachemeifyoucan cachemeifyoucan dismissed stale reviews from benlangmuir and DougGregor February 1, 2023 21:48

The base branch was changed.

@cachemeifyoucan
Copy link
Author

cachemeifyoucan commented Feb 1, 2023

Rebase onto stable/20221013

@cachemeifyoucan cachemeifyoucan force-pushed the eng/PR-VirtualOutputBackends-Improvements branch from 2655d80 to 89d16e8 Compare March 7, 2023 22:10
@cachemeifyoucan
Copy link
Author

cachemeifyoucan commented Mar 7, 2023

Please test with following pull request:
swiftlang/swift#63206

@swift-ci please test

@cachemeifyoucan
Copy link
Author

cachemeifyoucan commented Mar 8, 2023

@swift-ci please test macOS

@cachemeifyoucan
Copy link
Author

cachemeifyoucan commented Mar 8, 2023

Please test with following pull request:
swiftlang/swift#63206

@swift-ci please test macOS Platform

1 similar comment
@cachemeifyoucan
Copy link
Author

cachemeifyoucan commented Mar 17, 2023

Please test with following pull request:
swiftlang/swift#63206

@swift-ci please test macOS Platform

@cachemeifyoucan
[VirtualOutput] Add option to only overwrite output if content is dif…
1ed5a2b 
…ferent

Add new output configuration that checks if Output.keep() will change
the file content and skip overwriting when the content are the same.
This avoids updating file status for the output file like timestamps.
@cachemeifyoucan
[VirtualOutputBackend] Add HashingOutputBackend
6984b34 
Add a hashing outputbackend that can hash the outputs for sanity check.
@cachemeifyoucan
[lldb] Fix lldb build after swift ASTContext change
9db2c35
@cachemeifyoucan cachemeifyoucan force-pushed the eng/PR-VirtualOutputBackends-Improvements branch from 89d16e8 to 9db2c35 Compare April 3, 2023 03:13
@cachemeifyoucan
Copy link
Author

cachemeifyoucan commented Apr 3, 2023

Please test with following pull request:
swiftlang/swift#63206

@swift-ci please test

@cachemeifyoucan
Copy link
Author

cachemeifyoucan commented Apr 3, 2023

Please test with following pull request:
swiftlang/swift#63206

@swift-ci please test macOS Platform

1 similar comment
@cachemeifyoucan
Copy link
Author

cachemeifyoucan commented Apr 5, 2023

Please test with following pull request:
swiftlang/swift#63206

@swift-ci please test macOS Platform

@cachemeifyoucan
Copy link
Author

cachemeifyoucan commented Apr 5, 2023

Please test with following pull request:
swiftlang/swift#63206

@swift-ci please test macOS Platform

1 similar comment
@cachemeifyoucan
Copy link
Author

cachemeifyoucan commented Apr 5, 2023

Please test with following pull request:
swiftlang/swift#63206

@swift-ci please test macOS Platform

@cachemeifyoucan cachemeifyoucan merged commit 50a89bc into swiftlang:stable/20221013 Apr 5, 2023
@cachemeifyoucan cachemeifyoucan deleted the eng/PR-VirtualOutputBackends-Improvements branch April 5, 2023 15:34
@kavon kavon mentioned this pull request Apr 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akyrtzi akyrtzi Awaiting requested review from akyrtzi

@artemcm artemcm Awaiting requested review from artemcm

@jansvoboda11 jansvoboda11 Awaiting requested review from jansvoboda11

@DougGregor DougGregor Awaiting requested review from DougGregor

@benlangmuir benlangmuir Awaiting requested review from benlangmuir

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cachemeifyoucan @DougGregor @benlangmuir