[cmake][lldb] Fix header search path in unified builds #5321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After swiftlang/swift#60218 was merged, unified builds with CMake fail because the headers that used to be relative are not found in the header search path. Normal Swift builds rely on the else branch below these changes and use SWIFT_INCLUDE_DIRS, which was correctly updated in the PR linked above, but for the less used unified builds one has to be explicit about which header search path is needed.
compnerd
approved these changes
Sep 16, 2022
Member
|
@swift-ci please test |
etcwilde
approved these changes
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After swiftlang/swift#60218 was merged, unified builds with CMake fail because the headers that used to be relative are not found in the header search path.
Normal Swift builds rely on the else branch below these changes and use SWIFT_INCLUDE_DIRS, which was correctly updated in the PR linked above, but for the less used unified builds one has to be explicit about which header search path is needed.
/cc @egorzhdan @zoecarver @etcwilde @compnerd