Skip to content

[llvm/dwarfdump] Use the architecture string to filter. #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2019
Merged

[llvm/dwarfdump] Use the architecture string to filter. #440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion llvm/test/tools/llvm-dwarfdump/AArch64/arch.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
; RUN: llc -O0 %s -filetype=obj -o %t.o
; RUN: llvm-dwarfdump -arch arm64 %t.o | FileCheck %s
; RUN: llvm-dwarfdump -arch aarch64 %t.o | FileCheck %s
; RUN: llvm-dwarfdump -arch 0x0100000c %t.o | FileCheck %s
; CHECK: file format Mach-O arm64
;
Expand Down
4 changes: 4 additions & 0 deletions llvm/test/tools/llvm-dwarfdump/filter.test
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Make sure that passing --arch armv7s only shows the armv7s slice and not the armv7 slice.

RUN: llvm-dwarfdump -arch armv7s %S/../dsymutil/Inputs/fat-test.arm.dylib | FileCheck %s
CHECK-NOT: (armv7)
2 changes: 1 addition & 1 deletion llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ static bool filterArch(ObjectFile &Obj) {
return true;

// Match as name.
if (MachO->getArchTriple().getArch() == Triple(Arch).getArch())
if (MachO->getArchTriple().getArchName() == Triple(Arch).getArchName())
return true;
}
}
Expand Down