Add support for firmware/standalone LC_NOTE "main bin spec" corefiles #1864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a Mach-O corefile has an LC_NOTE "main bin spec" for a standalone binary / firmware, with only a UUID and no load address, try to locate the binary and dSYM by UUID and if found, load it at offset 0 for the user. Add a test case that tests a firmware/standalone corefile with both the "kern ver str" and "main bin spec" LC_NOTEs. <rdar://problem/68193804> Differential Revision: https://reviews.llvm.org/D88282 (cherry picked from commit 1bec6eb)
Author
|
@swift-ci please test |
1 similar comment
Author
|
@swift-ci please test |
ainu-bot
added a commit
to dabrahams/llvm-project
that referenced
this pull request
Oct 1, 2020
…ft/tensorflow-stage * 'swift/master' of github.com:apple/llvm-project: (26 commits) [Swift] Update for GenericParamList.h [LLVM 11] Add SystemZ changes to release notes [clang] Update warning-wall.c test [clang] Selectively ena/disa-ble format-insufficient-args warning Once we've found a firmware binary and loaded it, don't search more (swiftlang#1872) Add missing NodeType enums [ubsan] nullability-arg: Fix crash on C++ member pointers Fix DISubprogram-v4.ll after e17f52d Fix mysterious failure of SupportTests FileCheckTest.Binop [LLVM-C] Turn a ShuffleVector Constant Into a Getter. C API: functions to get mask of a ShuffleVector [CodeGen] Do not call `emitGlobalConstantLargeInt` for constant requires 8 bytes to store AArch64/GlobalISel: Narrow stack passed argument access size Add support for firmware/standalone LC_NOTE "main bin spec" corefiles (swiftlang#1864) [clang][module] Improve incomplete-umbrella warning [LLDB] Add a defensive check for member__f_ Add a verifier check that rejects non-distinct DISubprogram function attachments. They would crash the backend, which expects all DISubprograms that are not part of the type system to have a unit field. Revert "Add a verifier check that rejects non-distinct DISubprogram function" Fix Assembler/disubprogram.ll after e17f52d [profile] Add %t LLVM_PROFILE_FILE option to substitute $TMPDIR ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for firmware/standalone LC_NOTE "main bin spec" corefiles
When a Mach-O corefile has an LC_NOTE "main bin spec" for a
standalone binary / firmware, with only a UUID and no load
address, try to locate the binary and dSYM by UUID and if
found, load it at offset 0 for the user.
Add a test case that tests a firmware/standalone corefile
with both the "kern ver str" and "main bin spec" LC_NOTEs.
rdar://problem/68193804
Differential Revision: https://reviews.llvm.org/D88282
(cherry picked from commit 1bec6eb)