Add missing validity-check for SwiftASTContextReader #1442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a narrower version of swiftlang#1440 spun off for 5.3. I've kept 'scratch_ctx' wrapped in an Optional to minimize the necessary source changes. Simply removing the Optional triggers a subsequent assert because the context lock is not taken (even though the context reader is invalid). rdar://65276251
Author
|
@swift-ci test |
adrian-prantl
approved these changes
Jul 10, 2020
adrian-prantl
approved these changes
Jul 13, 2020
This was referenced Jul 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a narrower version of
#1440 spun off for 5.3.
I've kept 'scratch_ctx' wrapped in an Optional to minimize the necessary
source changes. Simply removing the Optional triggers a subsequent
assert because the context lock is not taken (even though the context
reader is invalid).
rdar://65276251