Skip to content

[clang] Fix missing target info specifier on Global Variable linkage computation #11006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2025
Merged

[clang] Fix missing target info specifier on Global Variable linkage computation #11006

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions clang/lib/CodeGen/CodeGenModule.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2759,7 +2759,7 @@ void CodeGenModule::SetInternalFunctionAttributes(GlobalDecl GD,
}

static void setLinkageForGV(llvm::GlobalValue *GV, const NamedDecl *ND,
VersionTuple EnclosingVersion = VersionTuple()) {
VersionTuple EnclosingVersion) {
// Set linkage and visibility in case we never see a definition.
LinkageInfo LV = ND->getLinkageAndVisibility();
// Don't set internal linkage on declarations.
Expand Down Expand Up @@ -5003,7 +5003,7 @@ CodeGenModule::GetOrCreateLLVMGlobal(StringRef MangledName, llvm::Type *Ty,

GV->setAlignment(getContext().getDeclAlign(D).getAsAlign());

setLinkageForGV(GV, D);
setLinkageForGV(GV, D, Target.getPlatformMinVersion());

if (D->getTLSKind()) {
if (D->getTLSKind() == VarDecl::TLS_Dynamic)
Expand Down