[lldb] Use RemoteAddress's address space for the file cache optimization #10979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that RemoteAddress carries its address space, instead of using a high bit to turn on the filecache optimization, use that instead. This way we are guaranteed to not clash with any pointer authentication masks. rdar://148361743
Author
|
@swift-ci test |
Author
kastiglione
approved these changes
Jul 11, 2025
kastiglione
left a comment
kastiglione
left a comment
There was a problem hiding this comment.
Is the use of the term "tagged address" still applicable?
Author
Yeah I was on the fence on that one... They're still "tagged" with the new address space, but I could change that to something else. |
Author
Author
|
@swift-ci test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that RemoteAddress carries its address space, instead of using a high bit to turn on the filecache optimization, use that instead. This way we are guaranteed to not clash with any pointer authentication masks.
rdar://148361743