[6.2][cherrypick] Backport upstream cherrypicks for OpenBSD from stable. #10885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenBSD now has sys/auxv.h but does not use getauxval.
TargetLoweringBase::getIRStackGuard refers to a platform-specific guard variable. Before this change, TargetLoweringBase::getSDagStackGuard only referred to a different variable. This means that SelectionDAGBuilder's getLoadStackGuard does not get memory operands. However, AArch64InstrInfo::expandPostRAPseudo assumes that the passed MachineInstr has nonzero memoperands, causing a segfault. We have two possible options here: either disabling the LOAD_STACK_GUARD node entirely in AArch64TargetLowering::useLoadStackGuardNode or just making the platform-specific values match across TargetLoweringBase. Here, we try the latter.
|
@swift-ci please test. |
JDevlieghere
approved these changes
Jun 22, 2025
|
Please merge on my behalf if OK, thanks! |
|
Ping; please merge on my behalf if OK, I don't have permissions. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reduce the need for manual patching of the swift/release/6.2 branch to ensure that the LLVM fork builds and runs successfully, backport these cherrypicks here too.
Changes are intended to affect OpenBSD only.
See OpenBSD port issue in swiftlang/swift#78437
#10883
Minimal, as changes are intended to affect only OpenBSD, have been upstreamed in LLVM HEAD and in the 20.x release for some time.
Original change has passed CI.
@JDevlieghere