Skip to content

[-Wunsafe-buffer-usage] Reland '[Clang] Optimize -Wunsafe-buffer-usage (#125492)' #10340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2025
Merged

[-Wunsafe-buffer-usage] Reland '[Clang] Optimize -Wunsafe-buffer-usage (#125492)' #10340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions clang/include/clang/Analysis/Analyses/UnsafeBufferUsageGadgets.def
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,12 @@
#define WARNING_OPTIONAL_GADGET(name) WARNING_GADGET(name)
#endif

/// A `WARNING_GADGET` subset, each of which corresponds to an unsafe
/// interaction with bounds-attributed constructs
#ifndef WARNING_BOUNDS_SAFETY_GADGET
#define WARNING_BOUNDS_SAFETY_GADGET(name) WARNING_GADGET(name)
#endif

/// Safe gadgets correspond to code patterns that aren't unsafe but need to be
/// properly recognized in order to emit correct warnings and fixes over unsafe
/// gadgets.
Expand All @@ -39,8 +45,8 @@ WARNING_GADGET(UnsafeBufferUsageAttr)
WARNING_GADGET(UnsafeBufferUsageCtorAttr)
WARNING_GADGET(DataInvocation)
// TO_UPSTREAM(BoundsSafety) ON
WARNING_GADGET(CountAttributedPointerArgument)
WARNING_GADGET(SinglePointerArgument)
WARNING_BOUNDS_SAFETY_GADGET(CountAttributedPointerArgument)
WARNING_BOUNDS_SAFETY_GADGET(SinglePointerArgument)
// TO_UPSTREAM(BoundsSafety) OFF
WARNING_OPTIONAL_GADGET(UnsafeLibcFunctionCall)
WARNING_OPTIONAL_GADGET(SpanTwoParamConstructor) // Uses of `std::span(arg0, arg1)`
Expand All @@ -58,4 +64,5 @@ FIXABLE_GADGET(PointerInit)
#undef FIXABLE_GADGET
#undef WARNING_GADGET
#undef WARNING_OPTIONAL_GADGET
#undef WARNING_BOUNDS_SAFETY_GADGET
#undef GADGET
Loading