Skip to content

Conversation

@compnerd
Copy link
Member

@compnerd compnerd commented May 1, 2020

This include path is needed to build SourceKit-LSP.

@benlangmuir
Copy link
Contributor

Could we change IndexStoreDB to use @_implementationOnly import CIndexStoreDB instead?

@compnerd
Copy link
Member Author

compnerd commented May 1, 2020

My opinion on that: that’s way better. I can try to see if I can get that to work.

Prevent the `CIndexStoreDB` import from leaking into clients by using
`@_implementationOnly`.  A couple of internal types need to be
type-erased to make this possible.  The typealiases are for `void *`, so
they can be easily replaced with `UnsafeMutableRawPointer`.
@benlangmuir
Copy link
Contributor

@swift-ci please test

@benlangmuir benlangmuir merged commit 77f4818 into swiftlang:master May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants