Remove --break-system-packages from Python lint job
#28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`--break-system-packages` was only needed when we ran in a Swift container and is an unknown option when running directly on the GitHub action runner.
|
Python lint is failing with the issue I’m fixing in this PR. |
PRs to github-workflows should use the version of the workflows that are updated by it, not the version that’s currently on `main`.
shahmishal
approved these changes
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--break-system-packageswas only needed when we ran in a Swift container and is an unknown option when running directly on the GitHub action runner.Also change the pull request workflow on this repo to use the workflows they are modified by PRs, not as they are defined on
mainbefore the PR was applied. This would have caught the Python-lint issue and allows me to unbreak it.