Ability to get if a nested namespace does not have a declare keyword

[dsherret]

Describe the feature

A TsModuleDecl has declare: true when within a nested namespace.

Ok(TsModuleDecl {
    span: span!(start),
    declare: self.ctx().in_declare,
    id: TsModuleName::Ident(id),
    body: Some(body),
    global: false,
})

So this means there's no way to tell if there's a declare keyword on the nested namespace.

declare module "@dsherret/package" {
    namespace packageName {
    }
}

Would it be possible to change the parser to only have declare on nodes that have a declare keyword?

[kdy1]

@dsherret As declare is invalid in ambient context, all children of a declare module should not be declare.

declare module "@dsherret/package" {
    declare namespace packageName {
    }
}

Results in error

[dsherret]

Yeah, I guess I could keep track of whether it's in a declare context or not.

[kdy1]

@dsherret I found a way to fix the issue. I'll fix it soon.

[dsherret]

Sweet. Thanks! No rush!

Yeah, it seems like babel and typescript both don't mark those nodes as "declare". TypeScript does use some flags to say the node is in an ambient context though.

[swc-bot]

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.