Skip to content
This repository was archived by the owner on Sep 14, 2022. It is now read-only.

Conversation

@hrldcpr
Copy link
Contributor

@hrldcpr hrldcpr commented Jul 20, 2017

The given example doesn't actually work, as discussed in #342

The given example doesn't actually work, as discussed in #342
@penx
Copy link

penx commented Feb 2, 2018

any reason this hasn't been merged yet?

@hrldcpr
Copy link
Contributor Author

hrldcpr commented Feb 2, 2018

@penx it looks like only one thing has been merged into this project since April 2017, so maybe development is paused at the moment

@penx
Copy link

penx commented Feb 2, 2018

Ah good point, thanks. Guess I’ll look for another mock util

@DanH42
Copy link

DanH42 commented Jun 7, 2018

Normally I hate bumping threads without having something to contribute, but I just wasted more time than I'd like to admit troubleshooting what turned out to be nothing (I wasn't seeing the behavior described in the documentation, therefore something must be wrong on my end).

This is a one-line change that fixes a simple mistake in the docs -- there's no code changes to review, tests to update, etc. #342 was reported over two years ago, and this one line is all that's needed to squash it. Looking at the list of folks who have accepted PRs recently, @shockey @webron @fehguy @micmro it would be great if someone could take a look at this and merge it.

@fehguy
Copy link
Contributor

fehguy commented Jun 7, 2018

Hi @DanH42 I'm off the project now but I bet @webron can click the green button for you! This is a simple fix.

@penx
Copy link

penx commented Jun 7, 2018

I ended up making https://github.com/penx/openapi-mock instead

@webron webron merged commit c13156b into swagger-api:master Aug 23, 2018
@hrldcpr hrldcpr deleted the patch-1 branch August 24, 2018 00:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants