Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/pretty-ties-help.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: skip generating $.proxy() calls for unary and binary expressions
Original file line number Diff line number Diff line change
Expand Up @@ -498,6 +498,8 @@ export function should_proxy(node) {
node.type === 'Literal' ||
node.type === 'ArrowFunctionExpression' ||
node.type === 'FunctionExpression' ||
node.type === 'UnaryExpression' ||
node.type === 'BinaryExpression' ||
(node.type === 'Identifier' && node.name === 'undefined')
) {
return false;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,18 @@ export default function Function_prop_no_getter($$anchor, $$props) {
let count = $.source(0);

function onmouseup() {
$.set(count, $.proxy($.get(count) + 2));
$.set(count, $.get(count) + 2);
}

const plusOne = (num) => num + 1;
/* Init */
var fragment = $.comment($$anchor);
var node = $.child_frag(fragment);

Button(node, {
onmousedown: () => $.set(count, $.proxy($.get(count) + 1)),
onmousedown: () => $.set(count, $.get(count) + 1),
onmouseup,
onmouseenter: () => $.set(count, $.proxy(plusOne($.get(count)))),
children: ($$anchor, $$slotProps) => {
/* Init */
var node_1 = $.space($$anchor);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,15 @@ export default function Function_prop_no_getter($$payload, $$props) {
count += 2;
}

const plusOne = (num) => num + 1;
const anchor = $.create_anchor($$payload);

$$payload.out += `${anchor}`;

Button($$payload, {
onmousedown: () => count += 1,
onmouseup,
onmouseenter: () => count = plusOne(count),
children: ($$payload, $$slotProps) => {
$$payload.out += `clicks: ${$.escape(count)}`;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@
function onmouseup() {
count += 2;
}

const plusOne = (num) => num + 1;
</script>

<Button onmousedown={() => count += 1} {onmouseup}>
<Button onmousedown={() => count += 1} {onmouseup} onmouseenter={() => count = plusOne(count)}>
clicks: {count}
</Button>