Skip to content

fix: adjust static attribute regex #9552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2023
Merged

fix: adjust static attribute regex #9552

merged 1 commit into from
Nov 20, 2023

Conversation

@dummdidumm
Copy link
Member

@dummdidumm dummdidumm commented Nov 20, 2023

Svelte 5 version of #9551

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@changeset-bot
Copy link

changeset-bot bot commented Nov 20, 2023

⚠️ No Changeset found

Latest commit: a6ceedb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Nov 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-5-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2023 9:10am

@dummdidumm dummdidumm merged commit 9926347 into main Nov 20, 2023
@dummdidumm dummdidumm deleted the regex-fix-v5 branch November 20, 2023 09:54
dominikg added a commit to sveltejs/vite-plugin-svelte that referenced this pull request Nov 20, 2023
@dominikg
fix: update regexes to correctly account for unquoted attribute value…
b31eab6 
…s, see sveltejs/svelte#9552
dominikg added a commit to sveltejs/vite-plugin-svelte that referenced this pull request Nov 21, 2023
@dominikg @bluwy
fix: use improved regex for script and style from svelte (#799)
c2017e0 
* fix: use improved regex for script and style from svelte

* fix: update regexes to correctly account for unquoted attribute values, see sveltejs/svelte#9552

* Update packages/vite-plugin-svelte/src/utils/error.js

Co-authored-by: Bjorn Lu <[email protected]>

---------

Co-authored-by: Bjorn Lu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trueadm trueadm trueadm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dummdidumm @trueadm