Skip to content

Conversation

@zqianem
Copy link
Contributor

@zqianem zqianem commented Jul 2, 2023

Ran into some small bumps in the svelte.dev instructions while trying to investigate another issue; this PR fixes them.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

zqianem added 2 commits July 2, 2023 08:39
After a clean clone, the `svelte` package needs to have its `/types`
directory generated for `pnpm dev` to work
Firefox supports `import` in workers since version 114; confirmed that
the REPL works with `pnpm dev` in Firefox
@dummdidumm dummdidumm merged commit 12f8e90 into sveltejs:master Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants