Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/gorgeous-jeans-begin.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: always mark props as stateful
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,10 @@ export function Identifier(node, context) {
context.state.expression.references.add(binding);
context.state.expression.has_state ||=
binding.kind !== 'static' &&
!binding.is_function() &&
(binding.kind === 'prop' ||
binding.kind === 'bindable_prop' ||
binding.kind === 'rest_prop' ||
!binding.is_function()) &&
!context.state.scope.evaluate(node).is_known;
}

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
import { flushSync } from 'svelte';
import { test } from '../../test';

export default test({
mode: ['client'],

test({ assert, target }) {
const btn = target.querySelector('button');

assert.htmlEqual(target.innerHTML, `<button>inc</button> Inner: 0 Inner: 0`);
btn?.click();
flushSync();
assert.htmlEqual(target.innerHTML, `<button>inc</button> Inner: 1 Inner: 1`);
}
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
<script>
let { getter } = $props()
</script>
Inner: {getter()}
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
<script>
import Wrapper1 from "./wrapper.svelte"
import Wrapper2 from "./wrapper2.svelte"
let count = $state(0);

let getter = $derived.by(() => {
const copy = count;
return () => copy;
});
</script>

<button onclick={() => count++}>inc</button>
<Wrapper1 {getter}/>
<Wrapper2 {getter}/>
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
<script >
import Inner from "./inner.svelte";

const { getter = () => -1} = $props();
</script>

<Inner {getter} />
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
<script >
import Inner from "./inner.svelte";

const { getter = $bindable(() => -1)} = $props();
</script>

<Inner {getter} />
Loading