Skip to content

fix: create fewer deriveds for concatenated strings #15041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 17, 2025
Merged

fix: create fewer deriveds for concatenated strings #15041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e235057
fix: create fewer deriveds for concatenated strings
Rich-Harris Jan 16, 2025
ffbe368
stringified_text -> expression
Rich-Harris Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/rich-donkeys-wink.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: create fewer deriveds for concatenated strings
4 changes: 2 additions & 2 deletions packages/svelte/src/compiler/phases/3-transform/client/visitors/shared/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@ export function build_template_chunk(values, visit, state) {
quasi.value.cooked += node.expression.value + '';
}
} else {
if (contains_multiple_call_expression) {
const id = b.id(state.scope.generate('stringified_text'));
if (node.metadata.expression.has_call && contains_multiple_call_expression) {
const id = b.id(state.scope.generate('expression'));
state.init.push(
b.const(
id,
Expand Down
6 changes: 3 additions & 3 deletions packages/svelte/tests/snapshot/samples/text-nodes-deriveds/_expected/client/index.svelte.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,11 @@ export default function Text_nodes_deriveds($$anchor) {
}

var p = root();
const stringified_text = $.derived(() => text1() ?? '');
const stringified_text_1 = $.derived(() => text2() ?? '');
const expression = $.derived(() => text1() ?? '');
const expression_1 = $.derived(() => text2() ?? '');
var text = $.child(p);

$.template_effect(() => $.set_text(text, `${$.get(stringified_text)}${$.get(stringified_text_1)}`));
$.template_effect(() => $.set_text(text, `${$.get(expression)}${$.get(expression_1)}`));
$.reset(p);
$.append($$anchor, p);
}
Loading