Skip to content

Conversation

@trueadm
Copy link
Contributor

@trueadm trueadm commented Dec 28, 2024

Fixes #14846. This ensures that we properly attach unowned deriveds to their dependencies. Previously, we might only attach one of the dependencies if that dependency was also a mismatched version – which meant we skipped all the other dependencies.

@changeset-bot
Copy link

changeset-bot bot commented Dec 28, 2024

🦋 Changeset detected

Latest commit: 3f8c7dd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@14855

@webJose
Copy link
Contributor

webJose commented Dec 28, 2024

BTW, the repro code in #14846 works in this PR's playground. Great job.

@gyzerok
Copy link
Contributor

gyzerok commented Jan 1, 2025

I've tried this fix in our codebase and it definitely improves memory profile. Some previously leakish stuff got fixed. Great job!

If possible would be great if it can be released in a version before unsafe branch, since the latter one seems a bit scary for us. Would be great if we could update to this fix and then take our time to check everything in the unsafe branch works correctly for us.

Copy link
Member

@baseballyama baseballyama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m not familiar with the Svelte 5 codebase, but this looks like the correct fix. It also worked fine in the REPL.

@trueadm trueadm merged commit 8148734 into main Jan 2, 2025
11 checks passed
@trueadm trueadm deleted the unowned-fix-2 branch January 2, 2025 16:54
@github-actions github-actions bot mentioned this pull request Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expressions inside {#if} blocks sometimes not correctly reactive to $derived properties of ES6 classes?

5 participants