Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fast-eyes-hear.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: ensure tree-shaken if blocks correctly hydrate
4 changes: 2 additions & 2 deletions packages/svelte/src/internal/client/dom/blocks/boundary.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import {
hydrate_node,
hydrating,
next,
remove_nodes,
traverse_nodes,
set_hydrate_node
} from '../hydration.js';
import { queue_micro_task } from '../task.js';
Expand Down Expand Up @@ -92,7 +92,7 @@ export function boundary(node, props, boundary_fn) {
} else if (hydrating) {
set_hydrate_node(hydrate_open);
next();
set_hydrate_node(remove_nodes());
set_hydrate_node(traverse_nodes(true));
}

if (failed) {
Expand Down
6 changes: 3 additions & 3 deletions packages/svelte/src/internal/client/dom/blocks/each.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import {
hydrate_next,
hydrate_node,
hydrating,
remove_nodes,
traverse_nodes,
set_hydrate_node,
set_hydrating
} from '../hydration.js';
Expand Down Expand Up @@ -160,7 +160,7 @@ export function each(node, flags, get_collection, get_key, render_fn, fallback_f

if (is_else !== (length === 0)) {
// hydration mismatch — remove the server-rendered DOM and start over
anchor = remove_nodes();
anchor = traverse_nodes(true);

set_hydrate_node(anchor);
set_hydrating(false);
Expand Down Expand Up @@ -199,7 +199,7 @@ export function each(node, flags, get_collection, get_key, render_fn, fallback_f

// remove excess nodes
if (length > 0) {
set_hydrate_node(remove_nodes());
set_hydrate_node(traverse_nodes(true));
}
}

Expand Down
11 changes: 7 additions & 4 deletions packages/svelte/src/internal/client/dom/blocks/if.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ import {
hydrate_next,
hydrate_node,
hydrating,
remove_nodes,
set_hydrate_node,
set_hydrating
set_hydrating,
traverse_nodes
} from '../hydration.js';
import { block, branch, pause_effect, resume_effect } from '../../reactivity/effects.js';
import { HYDRATION_START_ELSE } from '../../../../constants.js';
Expand Down Expand Up @@ -46,7 +46,7 @@ export function if_block(node, fn, elseif = false) {
/** @type {boolean | null} */ new_condition,
/** @type {null | ((anchor: Node) => void)} */ fn
) => {
if (condition === (condition = new_condition)) return;
if (condition === (condition = new_condition) && !hydrating) return;

/** Whether or not there was a hydration mismatch. Needs to be a `let` or else it isn't treeshaken out */
let mismatch = false;
Expand All @@ -57,11 +57,14 @@ export function if_block(node, fn, elseif = false) {
if (condition === is_else) {
// Hydration mismatch: remove everything inside the anchor and start fresh.
// This could happen with `{#if browser}...{/if}`, for example
anchor = remove_nodes();
anchor = traverse_nodes(true);

set_hydrate_node(anchor);
set_hydrating(false);
mismatch = true;
} else if (!fn) {
anchor = traverse_nodes();
set_hydrate_node(anchor);
}
}

Expand Down
7 changes: 5 additions & 2 deletions packages/svelte/src/internal/client/dom/hydration.js
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,9 @@ export function next(count = 1) {

/**
* Removes all nodes starting at `hydrate_node` up until the next hydration end comment
* @param {boolean} [remove]
*/
export function remove_nodes() {
export function traverse_nodes(remove = false) {
var depth = 0;
var node = hydrate_node;

Expand All @@ -99,7 +100,9 @@ export function remove_nodes() {
}

var next = /** @type {TemplateNode} */ (get_next_sibling(node));
node.remove();
if (remove) {
node.remove();
}
node = next;
}
}
1 change: 1 addition & 0 deletions packages/svelte/types/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1671,6 +1671,7 @@ declare module 'svelte/motion' {
* <input type="range" bind:value={spring.target} />
* <input type="range" bind:value={spring.current} disabled />
* ```
* @since 5.8.0
*/
export class Spring<T> {
constructor(value: T, options?: SpringOpts);
Expand Down
Loading