Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/nervous-adults-sell.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: ensure `$store` reads are properly transformed
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,17 @@ export function Program(_, context) {

for (const [name, binding] of context.state.scope.declarations) {
if (binding.kind === 'store_sub') {
const store = /** @type {Expression} */ (context.visit(b.id(name.slice(1))));
// read lazily, so that transforms added later are still applied
/** @type {Expression} */
let cached;

const get_store = () => {
return (cached ??= /** @type {Expression} */ (context.visit(b.id(name.slice(1)))));
};

context.state.transform[name] = {
read: b.call,
assign: (_, value) => b.call('$.store_set', store, value),
assign: (_, value) => b.call('$.store_set', get_store(), value),
mutate: (node, mutation) => {
// We need to untrack the store read, for consistency with Svelte 4
const untracked = b.call('$.untrack', node);
Expand All @@ -70,7 +76,7 @@ export function Program(_, context) {

return b.call(
'$.store_mutate',
store,
get_store(),
b.assignment(
mutation.operator,
/** @type {MemberExpression} */ (
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
import { flushSync } from 'svelte';
import { test } from '../../test';

export default test({
html: `<button>false</button>`,
test({ assert, target }) {
target.querySelector('button')?.click();
flushSync();
assert.htmlEqual(target.innerHTML, `<button>true</button>`);
}
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
<script>
import { writable } from 'svelte/store';
let data = { store: writable(false) };
let { store } = $derived(data);
</script>

<button onclick={() => ($store = true)}>{$store}</button>