breaking: remove $state.link callback
#12942
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #12938 (comment) (and #12545 for the original PR).
I regretted this API almost as soon as I merged it. Short of removing
$state.linkaltogether, I'm pretty certain that we should remove the callback version — if you need to do something more complicated than having a local piece of state immediately update when some other state changes, use an effect. Whether or not a dedicated API for the remaining use case (which is very narrow) is warranted is a live question, I think, but hopefully we can get agreement on this more limited change before too much damage is done from having the current version in the wild.Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.Tests and linting
pnpm testand lint the project withpnpm lint