Skip to content

fix: avoid extra work in mark_reactions #12921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 20, 2024
Merged

fix: avoid extra work in mark_reactions #12921

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7d835b
fix: avoid extra work in mark_reactions
trueadm Aug 20, 2024
c74a6f7
Update packages/svelte/src/internal/client/reactivity/sources.js
trueadm Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/flat-moose-arrive.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: avoid extra work in mark_reactions
4 changes: 2 additions & 2 deletions packages/svelte/src/internal/client/reactivity/sources.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,8 +145,8 @@ function mark_reactions(signal, status) {
var reaction = reactions[i];
var flags = reaction.f;

// Skip any effects that are already dirty
if ((flags & DIRTY) !== 0) continue;
// If a reaction is already dirty, skip it (but always mark unowned deriveds)
if ((flags & (CLEAN | UNOWNED)) === 0) continue;

// In legacy mode, skip the current effect to prevent infinite loops
if (!runes && reaction === current_effect) continue;
Expand Down