Skip to content

Conversation

@Rich-Harris
Copy link
Member

Alternative to #12752. This PR aligns Svelte with other frameworks like Solid and React, by treating <foo.bar> as a component tag rather than an element tag, since it is an invalid element name.

There is a lingering question over whether this would be problematic for Svelte Native, but I'm confident that another solution could be found there.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@changeset-bot
Copy link

changeset-bot bot commented Aug 11, 2024

🦋 Changeset detected

Latest commit: 519957a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@trueadm trueadm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@Conduitry
Copy link
Member

I think this change makes sense - but if we do this, we should include it in the list of breaking changes, since it also applies in non-runes mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants