fix: improved memory profile for transitions/animations #12796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b568ad3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Rich-Harris
reviewed
Aug 11, 2024
| animation.cancel(); | ||
| } | ||
| }) | ||
| .catch((e) => { |
Member
There was a problem hiding this comment.
The catch is necessary to prevent an unhandled rejection when a transition is aborted:
Contributor
Author
There was a problem hiding this comment.
Ah yeah, I remember now. That sucks :/ can't think of why it causes FF to leak. I've tried making the animation undefined inside it but that doesn't help.
Rich-Harris
approved these changes
Aug 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12719.
12759 previously would
nullthe effect on animation. I thought it wasn't necessary, but clearly it still is (I removed transitions from my example and forgot to put them back in, oops). I think we should flag this with Chromium folks as it seems odd that we need to do this – having it makes no difference in Firefox.I also noticed that the
catchfunction retains the animation in Firefox. I don't think we even need it anymore, so that fixes the memory leak in Firefox. Strangely, this doesn't seem to affect Chromium.Lastly, clearing
on_finishandon_abortseems to help the memory profile in Firefox and Chromium. Given we do it indeactivate, it makes sense to do inaborttoo.