Skip to content

breaking: play transitions on mount by default #12351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 8, 2024
Merged

breaking: play transitions on mount by default #12351

merged 2 commits into from
Jul 8, 2024

Conversation

dummdidumm
Copy link
Member

@dummdidumm dummdidumm commented Jul 8, 2024

closes #11280

During testing this I noticed two things:

  • in the added test, without |global the intro transition does not play within the component. Is that expected, because it's not inside any block (like an if block)?
  • HMR prevents playing the intro transition for some reason. We can investigate that separately if we don't want to hold up this PR

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Jul 8, 2024

🦋 Changeset detected

Latest commit: 9380a71

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

Is that expected

Yes — it's the same as if foo in {#if foo}{#if bar}<div in:fade>...</div>{/if}{/if} turned truthy — the transition wouldn't play

HMR prevents playing the intro transition for some reason

There's logic to disable transitions when the component is swapped out. Updated it so that it doesn't apply on first render

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte 5: default intro to true when using mount
2 participants