Skip to content

fix: skip deriveds for props with known safe calls #11595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2024
Merged

fix: skip deriveds for props with known safe calls #11595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/popular-apes-bathe.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: skip deriveds for props with known safe calls
10 changes: 7 additions & 3 deletions packages/svelte/src/compiler/phases/2-analyze/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1042,6 +1042,9 @@ function is_known_safe_call(node, context) {
return true;
}
}

// TODO add more cases

return false;
}

Expand Down Expand Up @@ -1262,11 +1265,12 @@ const common_visitors = {
}
},
CallExpression(node, context) {
const { expression } = context.state;
if (
context.state.expression?.type === 'ExpressionTag' ||
(context.state.expression?.type === 'SpreadAttribute' && !is_known_safe_call(node, context))
(expression?.type === 'ExpressionTag' || expression?.type === 'SpreadAttribute') &&
!is_known_safe_call(node, context)
) {
context.state.expression.metadata.contains_call_expression = true;
expression.metadata.contains_call_expression = true;
}

const callee = node.callee;
Expand Down