Skip to content

Conversation

@Rich-Harris
Copy link
Member

Knip lets us find code that isn't actually used in the project. I think it probably makes sense to get rid of this lot

@changeset-bot
Copy link

changeset-bot bot commented Jan 25, 2024

⚠️ No Changeset found

Latest commit: 33ba7d8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I vaguely remember that we wanted to keep this in so we don't forget? (yes you can do Git history searching but let's face it that's less likely to happen)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I just figured we'd probably start over given so much has changed since that was written. we can exclude it though if we want

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll defer to @trueadm on that one

@Rich-Harris
Copy link
Member Author

gonna merge this because this code keeps polluting my search results, and we can always find optimize.ts by coming back here

@Rich-Harris Rich-Harris merged commit dc8ca46 into main Jan 30, 2024
@Rich-Harris Rich-Harris deleted the knip branch January 30, 2024 20:04
trueadm pushed a commit that referenced this pull request Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants