Skip to content

Only parsing styles on-demand #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 19, 2023
Merged

Only parsing styles on-demand #358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8b13c92
Only parsing styles on-demand
marekdedic Jun 19, 2023
7c527eb
Added a changeset for on-demand style parsing
marekdedic Jun 19, 2023
325d573
Merge branch 'main' into on-demand-style-parsing
ota-meshi Jun 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/yellow-cats-impress.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"svelte-eslint-parser": minor
---

only parsing styles on-demand
5 changes: 4 additions & 1 deletion src/parser/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ export function parseForESLint(
const styleElement = ast.body.find(
(b): b is SvelteStyleElement => b.type === "SvelteStyleElement"
);
const styleContext = parseStyleContext(styleElement, ctx);
let styleContext: StyleContext | null = null;

resultScript.ast = ast as any;
resultScript.services = Object.assign(resultScript.services || {}, {
Expand All @@ -198,6 +198,9 @@ export function parseForESLint(
return resultTemplate.svelteAst.html;
},
getStyleContext() {
if (styleContext === null) {
styleContext = parseStyleContext(styleElement, ctx);
}
return styleContext;
},
styleNodeLoc,
Expand Down