fix: replace svelte.[assets|head|body] by sveltekit.[assets|head|body] #344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stephane-klein is attempting to deploy a commit to the Svelte Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Author
Member
|
Did you test this locally? I expect that it'd break the site because you're not bumping the SvelteKit version to a version where this change is present |
Author
|
@benmccann without this Pull Request commit: $ cd sites/hn.svelte.dev
$ npm list
[email protected] /home/stephane/git/github.com/sveltejs/sites/sites/hn.svelte.dev
├── @sveltejs/[email protected]
├── @sveltejs/[email protected]
├── [email protected]
├── [email protected]
└── [email protected]$ npm run devI go to http://127.0.0.1.3000 and I get this error: More info see sveltejs/kit#5016 @benmccann question: do you think that this pull request don't fix this breaking change? |
Member
|
It's because the instructions were showing npm instead of pnpm: a4ffe64 This change will break users who use pnpm because the lockfile isn't being updated as well |
Member
|
closing in favor of #345 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why? See sveltejs/kit#5016