Skip to content

Fixing minor syntax issue in example #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

TehShrike
Copy link
Member

Assuming that the function is supposed to return an object

@Conduitry
Copy link
Member

I would have just merged this in if I wasn't worried about it throwing off Rich when he went to push more commits to a branch that had changed. Maybe for tiny things like this use the new ```suggestion feature in PR comments?

@TehShrike
Copy link
Member Author

TehShrike commented Nov 2, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants