Update save.js #108
Merged
Update save.js #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A PR in SvelteKit introduces a number of breaking changes that
lay the foundation for streaming request/response bodies
enable multipart form handling (including file uploads)
better align SvelteKit with modern platforms that deal with `Request` and `Response` objects natively
Hooks (`handle`, `handleError` and `getSession`) and endpoints previously received a proprietary `Request` object:
```ts
interface Request<Locals = Record<string, any>, Body = unknown> {
url: URL;
method: string;
headers: RequestHeaders;
rawBody: RawBody;
params: Record<string, string>;
body: ParameterizedBody<Body>;
locals: Locals;
}
```
Instead, they now receive a `RequestEvent`:
```ts
export interface RequestEvent<Locals = Record<string, any>> {
request: Request; // https://developer.mozilla.org/en-US/docs/Web/API/Request
url: URL; // https://developer.mozilla.org/en-US/docs/Web/API/URL
params: Record<string, string>;
locals: Locals;
}
```
`method` and `headers` are no longer necessary as they exist on the `request` object. (`url` is still provided, since the `URL` object contains conveniences like `url.searchParams.get('foo')`, whereas `request.url` is a string.)
To access the request body use the text/json/arrayBuffer/formData methods, e.g. `body = await request.json()`.
See sveltejs/kit#3384 for details
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sveltejs/realworld/2gSMVuGZJ6qaM971ggdPmV8DTkbw |
benmccann
reviewed
Mar 2, 2022
Member
|
thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A PR in SvelteKit introduces a number of breaking changes that
lay the foundation for streaming request/response bodies
enable multipart form handling (including file uploads)
better align SvelteKit with modern platforms that deal with
RequestandResponseobjects nativelyHooks (
handle,handleErrorandgetSession) and endpoints previously received a proprietaryRequestobject:Instead, they now receive a
RequestEvent:methodandheadersare no longer necessary as they exist on therequestobject. (urlis still provided, since theURLobject contains conveniences likeurl.searchParams.get('foo'), whereasrequest.urlis a string.)To access the request body use the text/json/arrayBuffer/formData methods, e.g.
body = await request.json().See sveltejs/kit#3384 for details