fix: use non-existent package name for virtual module #9050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rich-Harris
approved these changes
Feb 14, 2023
Member
Rich-Harris
left a comment
Rich-Harris
left a comment
There was a problem hiding this comment.
LGTM assuming nothing breaks with the tests
Conduitry
reviewed
Feb 14, 2023
Rich-Harris
approved these changes
Feb 14, 2023
Merged
|
@Rich-Harris @benmccann good job in resolving this issue ASAP. Really appreciate the contribution being made by the team to the web development community. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9047
closes #9049
We mess around with
@sveltejs/kitinoptimizeDepsandssr.external/ssr.noExternal. Use a different package name to avoid that. That's probably also related to why the tests didn't catch this - Vite automatically handles pnpm linked packages differently