Skip to content

quote script in CSP directives #8372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 9, 2023
Merged

quote script in CSP directives #8372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5154a98
quote script in CSP directives - fixes #7442
Rich-Harris Jan 6, 2023
3ef524d
Merge branch 'master' into gh-7442
Rich-Harris Jan 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/stupid-actors-look.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/kit': patch
---

[fix] quote 'script' in CSP directives
3 changes: 2 additions & 1 deletion packages/kit/src/runtime/server/page/csp.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ const quoted = new Set([
'none',
'strict-dynamic',
'report-sample',
'wasm-unsafe-eval'
'wasm-unsafe-eval',
'script'
]);

const crypto_pattern = /^(nonce|sha\d\d\d)-/;
Expand Down
3 changes: 2 additions & 1 deletion packages/kit/test/apps/options/svelte.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@ const config = {
embedded: true,
csp: {
directives: {
'script-src': ['self']
'script-src': ['self'],
'require-trusted-types-for': ['script']
}
},
files: {
Expand Down
7 changes: 7 additions & 0 deletions packages/kit/test/apps/options/test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,13 @@ test.describe('CSP', () => {

await close();
});

test("quotes 'script'", async ({ page }) => {
const response = await page.goto(`/path-base`);
expect(response.headers()['content-security-policy']).toMatch(
/require-trusted-types-for 'script'/
);
});
});

test.describe('Custom extensions', () => {
Expand Down