[fix] check for private var usage in client code instead of server code #7487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e39a673 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
benmccann
changed the title
bluwy
approved these changes
Nov 4, 2022
Member
bluwy
left a comment
bluwy
left a comment
There was a problem hiding this comment.
LGTM. Make sense to move ssrLoadModule only after checking the illegal imports.
Member
|
Could we add some comments explaining why we use this other method, and use |
Member
Author
|
ok. I added a couple comments |
dummdidumm
approved these changes
Nov 4, 2022
This was referenced Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7288
Don't put the module into the graph with
ssrLoadModulewhich will add the server-side code, but instead useensureEntryFromUrlleaving thessrparameterundefined