Skip to content

Conversation

@Rich-Harris
Copy link
Member

closes #6160

@changeset-bot
Copy link

changeset-bot bot commented Aug 22, 2022

⚠️ No Changeset found

Latest commit: 843c737

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@elliott-with-the-longest-name-on-github
Copy link
Contributor

Should we add the same (or a "see here") text to the static public file?

@Rich-Harris
Copy link
Member Author

I was counting on "Similar to $env/static/private" being enough

@elliott-with-the-longest-name-on-github
Copy link
Contributor

Seems like we should be taking a different tact for documenting these:

$env

Stuff about all env vars

$env/static/*

Stuff about static env vars

`$env/dynamic/*

Stuff about dynamic env vars

$env/*/public

Stuff about public env vars

$env/*/private

Stuff about private env vars

There would be no "see here because they're the same" and much more logical/less repetitive grouping of concepts...

@Rich-Harris
Copy link
Member Author

Yeah, you're not wrong, though that would involve a much more comprehensive update to how this part of the documentation is automatically generated from the types

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to use undeclared static environment variables

3 participants