make 404 more helpful if paths.base is missing #5622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: de77f20 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
benmccann
reviewed
Jul 19, 2022
Co-authored-by: Ben McCann <[email protected]>
benmccann
approved these changes
Jul 19, 2022
dummdidumm
reviewed
Jul 20, 2022
| : path; | ||
|
|
||
| /** @type {(log: Logger, onError: OnError) => PrerenderErrorHandler} */ | ||
| function normalise_error_handler(log, onError) { |
Member
There was a problem hiding this comment.
Personal preference: I liked it better when this was a separate function (even if it's only used in one place). What was your reasoning for inlining it?
Member
Author
There was a problem hiding this comment.
The reason was that it needed to pass config to format_details... though I don't know why I didn't just pass config as an argument. fixing
dummdidumm
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5465. Before:
After:
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. All changesets should bepatchuntil SvelteKit 1.0