Skip to content

Conversation

@dummdidumm
Copy link
Member

Fixes #5415

The alternative fix would have been to do this in beforeunload, but this might result in more possibilities of flickering than the other way around.

I didn't know how to possibly write a test for this since this requires cross site navigation and a bfcache hit.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

Fixes #5415

The alternative fix would have been to do this in beforeunload, but this might result in more possibilities of flickering than the other way around.
@changeset-bot
Copy link

changeset-bot bot commented Jul 19, 2022

🦋 Changeset detected

Latest commit: e6ef21a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris merged commit c9f3e1e into master Jul 19, 2022
@Rich-Harris Rich-Harris deleted the bfcache-navigation branch July 19, 2022 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

With back-forward cache, SvelteKit docs get stuck in loading state after going back

3 participants