-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
[fix] handle binary data when prerendering #5497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
ed3c569
fix: corrupted images when using adapter-static
gbkwiatt 6f840a6
fix: lint fix
gbkwiatt d17aa42
chore: lint fix
gbkwiatt 550fd5e
Merge branch 'master' into pr/5497
Conduitry 51ffed4
always use Buffer
Conduitry 6605846
Create popular-plants-begin.md
benmccann c214d13
added test for binary files after prerender
ddcdb8a
linting
937cc4f
added node fetch and fix linting
e061fe9
changed get to GET as per latest kit
94f0707
using local images for test instead of urls and fetch
e814b60
Update packages/kit/test/prerendering/basics/test/test.js
Rich-Harris 035a2ca
Update packages/kit/test/prerendering/basics/test/test.js
Rich-Harris File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@sveltejs/kit": patch | ||
| --- | ||
|
|
||
| [fix] handle binary data when prerendering |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
packages/kit/test/prerendering/basics/src/routes/fetch-image.svelte
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| <img src="/fetch-image/image.jpg" alt="" /> | ||
| <img src="/fetch-image/image.png" alt="" /> |
16 changes: 16 additions & 0 deletions
16
packages/kit/test/prerendering/basics/src/routes/fetch-image/[...slug]/index.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| import * as fs from 'fs'; | ||
|
|
||
| export async function GET({ params }) { | ||
| const slug = params.slug.split('/'); | ||
| const extension = slug[0].split('.').pop(); | ||
|
|
||
| const file = fs.readFileSync(`./static/image.${extension}`); | ||
|
|
||
| return { | ||
| status: 200, | ||
| headers: { | ||
| 'Content-Type': 'image/' + extension | ||
| }, | ||
| body: file | ||
| }; | ||
| } |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.