Skip to content

fix: add redirects for routes containing '__data.json' suffix #5180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 22, 2022
Merged

fix: add redirects for routes containing '__data.json' suffix #5180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5dadd8d
fix: add redirect for routes containing __data.json suffix
ericapisani Jun 7, 2022
fb8906f
fix: await for builder.createEntries to complete before writing redir…
ericapisani Jun 7, 2022
ee3ac20
chore: add changeset entry
ericapisani Jun 7, 2022
407ed72
Merge branch 'sveltejs:master' into ep/4872-split-config
ericapisani Jun 9, 2022
74d63c3
Update tasty-zebras-guess.md
Rich-Harris Jun 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tasty-zebras-guess.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/adapter-netlify': patch
---

fix: add redirects for routes containing `__data.json` suffix
5 changes: 3 additions & 2 deletions packages/adapter-netlify/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ async function generate_edge_functions({ builder }) {
* @param { boolean } params.split
* @param { boolean } params.esm
*/
function generate_lambda_functions({ builder, publish, split, esm }) {
async function generate_lambda_functions({ builder, publish, split, esm }) {
builder.mkdirp('.netlify/functions-internal');

/** @type {string[]} */
Expand All @@ -177,7 +177,7 @@ function generate_lambda_functions({ builder, publish, split, esm }) {
if (split) {
builder.log.minor('Generating serverless functions...');

builder.createEntries((route) => {
await builder.createEntries((route) => {
const parts = [];
// Netlify's syntax uses '*' and ':param' as "splats" and "placeholders"
// https://docs.netlify.com/routing/redirects/redirect-options/#splats
Expand Down Expand Up @@ -211,6 +211,7 @@ function generate_lambda_functions({ builder, publish, split, esm }) {
writeFileSync(`.netlify/functions-internal/${name}.js`, fn);

redirects.push(`${pattern} /.netlify/functions/${name} 200`);
redirects.push(`${pattern}/__data.json /.netlify/functions/${name} 200`);
}
};
});
Expand Down